-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: enable object-curly-newline & object-property-newline.(fixes #9042) #9068
Conversation
LGTM |
Personally, I prefer putting everything on a new line in that case: context.report({
node,
message,
data: { name: node.name }
}); |
agree. is there a rule or option to enforce this? I thought |
I think |
what if I want to allow (all in one line): var foo = { key1: 1, key2: 2, key3: 3 }; and per property per line: var foo = {
key1: 1,
key2: 2,
key3: 3,
}; just report inconsistent properties like this: var foo = {
key1: 1, key2: 2,
key3: 3
}; this is exactly we are using. |
LGTM |
2 similar comments
LGTM |
LGTM |
Does the |
oh, sorry, it does. I just missed something. updated the commits. also enable object-property-newline. and it looks better. @not-an-aardvark ,thanks for your patience! ❤️ |
Thanks for the pull request, @aladdin-add! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
LGTM |
LGTM |
Yeah, the option name is a bit misleading :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
enalbe object-curly-newline.(fixes #9042)
Is there anything you'd like reviewers to focus on?
Personally I see the fixed code looks a little strange:
any thoughts?